From: Eric Sandeen Subject: Re: [PATCH V2] fix type of "offset" in ext4_io_end Date: Sat, 30 Jan 2010 12:33:57 -0600 Message-ID: <4B647B95.7070206@redhat.com> References: <4B6327C4.4000100@redhat.com> <4B6344E7.9050503@redhat.com> <20100130173458.GB788@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ext4 development , Giel de Nijs To: tytso@mit.edu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18753 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280Ab0A3SeD (ORCPT ); Sat, 30 Jan 2010 13:34:03 -0500 In-Reply-To: <20100130173458.GB788@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: tytso@mit.edu wrote: > On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote: >> The "offset" member in ext4_io_end holds bytes, not >> blocks, so ext4_lblk_t is wrong - and too small (u32) >> >> This caused the testcase "Possible ext4 data corruption >> with large files and async I/O" sent by Giel to fail when it >> wrapped around to 0. >> >> Also fix up the type of arguments to >> ext4_convert_unwritten_extents(), it gets ssize_t from >> ext4_end_aio_dio_nolock() and ext4_ext_direct_IO() >> >> Reported-by: Giel de Nijs >> Signed-off-by: Eric Sandeen >> --- > > This looks important enough (and low risk enough) to push to Linus > before the next merge window. Comments? > > - Ted yeah, I think so. if there's any concern over the size_t type changes I could split it up. -Eric