From: Eric Sandeen Subject: Re: [PATCH] ext4: memory leakage in ext4_mb_init() Date: Sun, 04 Apr 2010 23:59:00 -0500 Message-ID: <4BB96E14.9010903@redhat.com> References: <20100322012758.GE11560@thunk.org> <87sk7nv4sp.fsf@linux.vnet.ibm.com> <20100403165340.GA17819@thunk.org> <20100404180845.GG18524@thunk.org> <4BB966AE.1060207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: tytso@mit.edu, "Aneesh Kumar K. V" , linux-ext4 , Andreas Dilger , Dave Kleikamp To: jing zhang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20096 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749Ab0DEE7J (ORCPT ); Mon, 5 Apr 2010 00:59:09 -0400 In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: jing zhang wrote: > 2010/4/5, Eric Sandeen : >> jing zhang wrote: >>> 2010/4/5, tytso@mit.edu : >>>> On Sun, Apr 04, 2010 at 09:05:14AM +0800, jing zhang wrote: >>>> >>>> How much testing are you doing before submitting patches, out of >>>> curiosity? >>> Yes, Ted, it is curiosity that drives me to do hard works, including patch >>> ext4. >> It is the language barrier that is making some of this difficult, >> but I'm not complaining - you speak English much better than I speak any > > You are good guy:) Is English your native language? And, I am curious, > what is the second language you are able to speak, Eric? Only a little German. >> second language. :) >> >> Ted meant that -he- was curious about how much testing you were doing. > > How do know what Ted meant, by iphone? No, because I am a native English speaker and I understood the figure of speech. ("out of curiosity") > I am not good at testing, partially because it is hard to setup the > required environment, sometimes several hard disks are needed, maybe a > few boxes, but I try to analyse the C code while reading and > understanding the works by great maintainers and developers of Linux > kernel. Testing really is critical to development; some things can be done by inspection, but if you don't test it is hard to know if you made a mistake. You can always test inside a vm, or on a loopback file, on a single box. Without testing, you are asking others to do testing for you (unless the change is so obvious that it can be trusted) -Eric > - zj