From: Joel Becker Subject: Re: [Ocfs2-devel] [PATCH 2/2] OCFS2: Allow huge (> 16 TiB) volumes to mount Date: Tue, 13 Jul 2010 01:10:13 -0700 Message-ID: <20100713081013.GA31479@mail.oracle.com> References: <871vbax86w.fsf@patl.com> <87zkxyvtjt.fsf@patl.com> <3BB069D5-B193-43A4-B678-B3CEA4873B58@dilger.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andreas Dilger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com To: "Patrick J. LoPresti" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Mon, Jul 12, 2010 at 10:00:10PM -0700, Patrick J. LoPresti wrote: > On Mon, Jul 12, 2010 at 9:46 PM, Andreas Dilger w= rote: > > On 2010-07-12, at 19:08, Patrick J. LoPresti wrote: > >> > >> Are you suggesting I need to do this before my patch is accepted a= t > >> all? =A0Or is this a refactoring that can happen later? > > > > I'm just suggesting it should be done at some point. =A0I thought i= t would be better to do it first, rather than add yet another copy of t= his code. =A0That said, I hate to block useful fixes because of cleanup= (and I have no control over OCFS2 anyway :-). =A0However, I've found t= hat once the fix is in people usually forget (or become too busy) to do= the cleanup and it just lingers on unseen. >=20 > I hear you. >=20 > I do not object to factoring out the basic addressability test and > using it in my patch, leaving it for others -- like yourself :-) -- t= o > modify other file systems to invoke it. I think you should modify ext3 and xfs, as they clearly are partaking of this functionality. I'll happily review it for you. Put the call in fs/libfs.c. Call it generic_check_addressable(struct super_block *super). Joel --=20 "The only way to get rid of a temptation is to yield to it." - Oscar Wilde=20 Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html