From: Wang Sheng-Hui Subject: [PATCH] ext2: return -ENODATA for NULL i_file_acl in ext2_xattr_list Date: Tue, 13 Jul 2010 22:55:21 +0800 Message-ID: <4C3C7E59.8040905@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit To: kernel-janitors , linux-ext4 , linux-kernel Return-path: Received: from mail-px0-f174.google.com ([209.85.212.174]:57432 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756313Ab0GMOzK (ORCPT ); Tue, 13 Jul 2010 10:55:10 -0400 Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi, In ext2_xattr_list, if (!EXT2_I(inode)->i_file_acl) is true, we should return -ENODATA instead of 0. Following patch is against 2.6.35-rc5. Please check it. Signed-off-by: Wang Sheng-Hui --- fs/ext2/xattr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index 7c39157..5ecbbd8 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -263,7 +263,7 @@ ext2_xattr_list(struct dentry *dentry, char *buffer, size_t buffer_size) buffer, (long)buffer_size); down_read(&EXT2_I(inode)->xattr_sem); - error = 0; + error = -ENODATA; if (!EXT2_I(inode)->i_file_acl) goto cleanup; ea_idebug(inode, "reading block %d", EXT2_I(inode)->i_file_acl); -- 1.7.1.1 -- Thanks and Regards, shenghui