From: Joel Becker Subject: Re: [Ocfs2-devel] [PATCH 2/3] JBD2: Allow feature checks before journal recovery Date: Thu, 12 Aug 2010 16:03:53 -0700 Message-ID: <20100812230353.GE22777__29351.388596888$1281654314$gmane$org@mail.oracle.com> References: <874ofr2myq.fsf@patl.com> <8739vb2mxr.fsf@patl.com> <20100812174318.GD6561@mail.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Jan Kara , "Ted Ts'o" , "Patrick J. LoPresti" , ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:52840 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761034Ab0HLXEd (ORCPT ); Thu, 12 Aug 2010 19:04:33 -0400 Content-Disposition: inline In-Reply-To: <20100812174318.GD6561@mail.oracle.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Aug 12, 2010 at 10:43:19AM -0700, Joel Becker wrote: > On Thu, Jul 22, 2010 at 03:04:16PM -0700, Patrick J. LoPresti wrote: > > Before we start accessing a huge (> 16 TiB) OCFS2 volume, we need to > > confirm that its journal supports 64-bit offsets. In particular, we > > need to check the journal's feature bits before recovering the journal. > > > > This is not possible with JBD2 at present, because the journal > > superblock (where the feature bits reside) is not loaded from disk until > > the journal is recovered. > > > > This patch loads the journal superblock in > > jbd2_journal_check_used_features() if it has not already been loaded, > > allowing us to check the feature bits before journal recovery. > > > > Signed-off-by: Patrick LoPresti > > Dear jbd2 developers, > I've pushed this patch to the merge-window branch of ocfs2.git. > I'm ready to send it to Linus, but I need your OK. To be specific, I'd really like an Acked-by. Joel -- "The doctrine of human equality reposes on this: that there is no man really clever who has not found that he is stupid." - Gilbert K. Chesterson Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127