From: Joel Becker Subject: Re: [Ocfs2-devel] [PATCH 2/3] JBD2: Allow feature checks before journal recovery Date: Fri, 13 Aug 2010 00:17:25 -0700 Message-ID: <20100813071720.GA21279@mail.oracle.com> References: <874ofr2myq.fsf@patl.com> <8739vb2mxr.fsf@patl.com> <20100812174318.GD6561@mail.oracle.com> <20100813033930.GG2763@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: "Ted Ts'o" , Jan Kara , "Patrick J. LoPresti" , ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Return-path: Content-Disposition: inline In-Reply-To: <20100813033930.GG2763@thunk.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Thu, Aug 12, 2010 at 11:39:30PM -0400, Ted Ts'o wrote: > On Thu, Aug 12, 2010 at 10:43:19AM -0700, Joel Becker wrote: > > On Thu, Jul 22, 2010 at 03:04:16PM -0700, Patrick J. LoPresti wrote: > > > Before we start accessing a huge (> 16 TiB) OCFS2 volume, we need to > > > confirm that its journal supports 64-bit offsets. In particular, we > > > need to check the journal's feature bits before recovering the journal. > > > > > > This is not possible with JBD2 at present, because the journal > > > superblock (where the feature bits reside) is not loaded from disk until > > > the journal is recovered. > > > > > > This patch loads the journal superblock in > > > jbd2_journal_check_used_features() if it has not already been loaded, > > > allowing us to check the feature bits before journal recovery. > > > > > > Signed-off-by: Patrick LoPresti > > > > Dear jbd2 developers, > > I've pushed this patch to the merge-window branch of ocfs2.git. > > I'm ready to send it to Linus, but I need your OK. > > Signed-off-by: "Theodore Ts'o" Thanks Ted! Joel -- "I don't even butter my bread; I consider that cooking." - Katherine Cebrian Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127