From: Masayoshi MIZUMA <m.mizuma@jp.fujitsu.com>
Subject: Re: [PATCH] ext3: set i_extra_isize of 11th inode
Date: Mon, 23 Aug 2010 09:16:58 +0900
Message-ID: <20100823091657.ACB6.61FB500B@jp.fujitsu.com>
References: <20100820112011.E6FA.61FB500B@jp.fujitsu.com> <0347DFC8-03A9-45DF-9B9F-ED4005720C49@dilger.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
	linux-ext4 <linux-ext4@vger.kernel.org>
To: Andreas Dilger <adilger.kernel@dilger.ca>
In-Reply-To: <0347DFC8-03A9-45DF-9B9F-ED4005720C49@dilger.ca>
Sender: linux-ext4-owner@vger.kernel.org

On Fri, 20 Aug 2010 01:42:25 -0600
Andreas Dilger <adilger@dilger.ca> wrote:

> On 2010-08-19, at 20:20, Masayoshi MIZUMA wrote:
> > In ext3 filesystem, if following conditions 1., 2., 3. and 4. is satisfied,
> > getfattr can't search the extended attribute (EA) after remount.
> > 
> > This happens because of following logic:
> >    i_extra_isize is set to over 0 by ext3_new_inode() when we create
> >    a file whose inode number is 11 after removing "lost+found". 
> >    Therefore setfattr creates the EA in-inode.
> >    After remount, i_extra_isize of 11th inode is set to 0 by ext3_iget()
> >    when we lookup the file, so getfattr tries to search the EA out-inode.
> >    However, the EA locates in-inode, so getfattr can't search the EA.
> 
> This was a workaround for a bug in mke2fs a couple of years ago, and is probably no longer needed.
I understand it. Thanks.

> 
> > @@ -2881,8 +2881,7 @@ struct inode *ext3_iget(struct super_block *sb, unsigned long ino)
> > 		atomic_set(&ei->i_datasync_tid, tid);
> > 	}
> > 
> > -	if (inode->i_ino >= EXT3_FIRST_INO(inode->i_sb) + 1 &&
> > -	    EXT3_INODE_SIZE(inode->i_sb) > EXT3_GOOD_OLD_INODE_SIZE) {
> > +	if (EXT3_INODE_SIZE(inode->i_sb) > EXT3_GOOD_OLD_INODE_SIZE) {
> > 		/*
> > 		 * When mke2fs creates big inodes it does not zero out
> > 		 * the unused bytes above EXT3_GOOD_OLD_INODE_SIZE,
> 
> This should also remove the above comment, which is no longer relevant.
OK. I will resend the patch which is removed the above comment.

Thanks,
Masayoshi