From: Masayoshi MIZUMA <m.mizuma@jp.fujitsu.com>
Subject: Re: [PATCH] [RESEND] ext3: set i_extra_isize of 11th inode
Date: Thu, 26 Aug 2010 10:25:36 +0900
Message-ID: <20100826102535.C327.61FB500B@jp.fujitsu.com>
References: <20100826003657.GN4453@thunk.org> <6B0D8B5D-C576-4DC2-B390-9D1EB8B6A5BA@dilger.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: Jan Kara <jack@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
	"Ted Ts'o" <tytso@mit.edu>
In-Reply-To: <6B0D8B5D-C576-4DC2-B390-9D1EB8B6A5BA@dilger.ca>
Sender: linux-ext4-owner@vger.kernel.org

On Wed, 25 Aug 2010 18:55:49 -0600
Andreas Dilger <adilger@dilger.ca> wrote:

> On 2010-08-25, at 18:36, Ted Ts'o wrote:
> > On Wed, Aug 25, 2010 at 05:39:11PM -0600, Andreas Dilger wrote:
> >> 
> >> The fix to e2fsck for this issue has been around for a long time,
> >> AFAIK.  It was only needed in the kernel while the broken mke2fs was
> >> in wide use, and before a fixed e2fsck was available.
> > 
> > The mke2fs in question was fixed in e2fsprogs 1.37, over five years
> > ago.  Mizuma-san, why are you using such an __ancient__ mke2fs?  It
> > would seem that instead of fixing the kernel, the better thing to do
> > is to fix your version of e2fsprogs.
> 
> I think you are missing the point.  I don't think it matters which mke2fs is in use.  The problem is that ext3_iget() has a workaround for this 5-year-old mke2fs bug that is actively causing a loss of xattr data if lost+found is reallocated.
I used e2fsprogs 1.41. I think this problem isn't mke2fs's problem,
so I agree with Andreas.


Thanks,
Masayoshi