From: Ted Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue
Date: Sat, 25 Sep 2010 19:54:59 -0400
Message-ID: <20100925235459.GA5299@thunk.org>
References: <1285439521-2557-1-git-send-email-tdent48227@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: adilger.kernel@dilger.ca, jack@suse.cz, dmonakhov@openvz.org,
	sandeen@redhat.com, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Tracey Dent <tdent48227@gmail.com>
Content-Disposition: inline
In-Reply-To: <1285439521-2557-1-git-send-email-tdent48227@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org

On Sat, Sep 25, 2010 at 02:31:52PM -0400, Tracey Dent wrote:
> From: Tracey Dent <Tdent48227@gmail.com>
> 
> Found and corrected indent issue using checkpatch.pl
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>

Patches that fix whitespace issues aren't really worthwhile.  They
tend to cause extra work for the me as the maintainer, since it means
that patches that others send me end up failing due to whitespace
issues, which then have to be manually fixed up.

There are also changes you've made which actually make the alignment
*worse* not better, places where you changed:

	} else if

to
	}	else if

which is to my mind, totally broken, and certainly not required by
checkpatch.

So I'm going to NACK this whole patch series, sorry.

Patches should be checkpatch.pl clean, and so as we make changes,
we'll also gradually clean up the code.  Note though that I'm an emacs
user, and so I prefer code where parenthesis is properly lined up,
i.e.:

	while ((count < blks) && (count <= blocks_to_boundary) &&
	       (le32_to_cpu(*(branch[0].p + count)) == 0)) {

and not this:

	while ((count < blks) && (count <= blocks_to_boundary) &&
		(le32_to_cpu(*(branch[0].p + count)) == 0)) {

I won't insist on it, though.  However, I'll generally clean up such
alignment issues if I come across it.

;					- Ted