From: Joe Perches Subject: Re: [PATCH 01/10] Fs: ext4: acl.c: fixed indent issue Date: Sat, 25 Sep 2010 18:32:26 -0700 Message-ID: <1285464746.6115.108.camel@Joe-Laptop> References: <1285439521-2557-1-git-send-email-tdent48227@gmail.com> <20100925233600.GA2854@lst.de> <20100925235643.GA3224@lst.de> <20100926000154.GB5299@thunk.org> <1285459769.6115.74.camel@Joe-Laptop> <20100926003255.GA19690@thunk.org> <1285462243.6115.89.camel@Joe-Laptop> <20100926010410.GC19690@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , T Dent , adilger.kernel@dilger.ca, jack@suse.cz, dmonakhov@openvz.org, sandeen@redhat.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Ted Ts'o , Andy Whitcroft Return-path: Received: from mail.perches.com ([173.55.12.10]:2399 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607Ab0IZBc3 (ORCPT ); Sat, 25 Sep 2010 21:32:29 -0400 In-Reply-To: <20100926010410.GC19690@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, 2010-09-25 at 21:04 -0400, Ted Ts'o wrote: > But the stupid thing is > trying to do it on a file-by-file basis in the first place, when for > something like fs/ext4, it really should be done on a subdirectory > basis. That's not true at all. If there's a listed maintainer linked to a pattern like "F: fs/ext4/", then all files in that directory and any subdirectories are "maintained". If a maintainer wants to "exclude" particular files, or subdirectories, that's possible with the "X:" tag. > What really annoys me is newbies who use checkpatch.pl in its --file > mode, and then assume that every single warning is a deadly bug that > much be patched. Perhaps checkpatch.pl should print some "don't submit patches for stupid stuff" when used with -f. > I at least never use it. Nor are you required to. Tool use is optional. I don't care if you carve patches with a mallet onto stone tablets and send them by swarms of carrier pigeon to Linus so can reuse the stone to build an actual castle. cheers, Joe