From: Brad Boyer Subject: Re: [PATCH 2/6] [RFC] Create the .relink file_operation Date: Sun, 26 Sep 2010 12:08:37 -0700 Message-ID: <20100926190837.GA9308@cynthia.pants.nu> References: <6987185123220ec2034677299859c5a63eaf2aed.1285278339.git.matthltc@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "Theodore Ts'o" , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Andreas Dilger , Al Viro , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jan Kara , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Helsley Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-ext4.vger.kernel.org On Thu, Sep 23, 2010 at 02:53:28PM -0700, Matt Helsley wrote: > Not all filesystems will necessarily be able to support relinking an > orphan inode back into the filesystem. Some offlist feedback suggested > that instead of overloading .link that relinking should be a separate > file operation for this reason. > > Since .relink is a superset of .link make the VFS call .relink where > possible and .link otherwise. > > The next commit will change ext3/4 to enable this operation. I may have missed something in one of these patches (patch 1 and any original summary if there was one don't appear in my email), but what is the point of the new operation? I didn't see any case that treats one any different than the other. What is disallowed (and how) for a driver which does not implement .relink but has .link? Brad Boyer flar-POGeQm5F+FGB+jHODAdFcQ@public.gmane.org