From: Jan Kara Subject: Re: [PATCH] jbd: Move debug message into #ifdef area Date: Mon, 4 Oct 2010 11:39:48 +0200 Message-ID: <20101004093948.GB3589@quack.suse.cz> References: <1286180813-4653-1-git-send-email-namhyung@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Namhyung Kim Return-path: Received: from cantor2.suse.de ([195.135.220.15]:50884 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015Ab0JDJkm (ORCPT ); Mon, 4 Oct 2010 05:40:42 -0400 Content-Disposition: inline In-Reply-To: <1286180813-4653-1-git-send-email-namhyung@gmail.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon 04-10-10 17:26:53, Namhyung Kim wrote: > Move call to jbd_debug() into #ifdef CONFIG_JBD_DEBUG block because > 'dropped' is declared there. The code could be compiled without this > change anyway, simply because jbd_debug() expands to nothing if > !CONFIG_JBD_DEBUG but IMHO it doesn't look good in general. > > Signed-off-by: Namhyung Kim Thanks. Merged into my tree. Honza > --- > fs/jbd/recovery.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c > index 81051da..5b43e96 100644 > --- a/fs/jbd/recovery.c > +++ b/fs/jbd/recovery.c > @@ -296,10 +296,10 @@ int journal_skip_recovery(journal_t *journal) > #ifdef CONFIG_JBD_DEBUG > int dropped = info.end_transaction - > be32_to_cpu(journal->j_superblock->s_sequence); > -#endif > jbd_debug(1, > "JBD: ignoring %d transaction%s from the journal.\n", > dropped, (dropped == 1) ? "" : "s"); > +#endif > journal->j_transaction_sequence = ++info.end_transaction; > } > > -- > 1.7.0.4 > -- Jan Kara SUSE Labs, CR