From: Avi Kivity Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Date: Tue, 16 Nov 2010 14:25:35 +0200 Message-ID: <4CE2783F.1020004@redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Josef Bacik Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933374Ab0KPMZz (ORCPT ); Tue, 16 Nov 2010 07:25:55 -0500 In-Reply-To: <1289840723-3056-5-git-send-email-josef@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 11/15/2010 07:05 PM, Josef Bacik wrote: > Ext4 doesn't have the ability to punch holes yet, so make sure we return > EOPNOTSUPP if we try to use hole punching through fallocate. This support can > be added later. Thanks, > Instead of teaching filesystems to fail if they don't support the capability, why don't supporting filesystems say so, allowing the fail code to be in common code? -- error compiling committee.c: too many arguments to function