From: Eric Sandeen Subject: Re: [patch] fix up lock order reversal in writeback Date: Thu, 18 Nov 2010 12:04:21 -0600 Message-ID: <4CE56AA5.4030705@redhat.com> References: <20101116110058.GA4298@amd> <20101116130146.GG4757@quack.suse.cz> <4CE35A6D.2040906@redhat.com> <20101117043845.GA3586@amd> <4CE362B0.6040607@redhat.com> <20101117061057.GA3989@amd> <20101118030613.GQ3290@thunk.org> <20101117192900.da859ac7.akpm@linux-foundation.org> <20101118060000.GA3509@amd> <20101117222834.2bb36ee1.akpm@linux-foundation.org> <4CE53E56.4090501@redhat.com> <20101118091053.c275e1f2.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Nick Piggin , "Ted Ts'o" , Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org To: Andrew Morton Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64190 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755220Ab0KRSFW (ORCPT ); Thu, 18 Nov 2010 13:05:22 -0500 In-Reply-To: <20101118091053.c275e1f2.akpm@linux-foundation.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 11/18/10 11:10 AM, Andrew Morton wrote: > On Thu, 18 Nov 2010 08:55:18 -0600 Eric Sandeen wrote: > >>> Can we just delete writeback_inodes_sb_nr_if_idle() and >>> writeback_inodes_sb_if_idle()? The changelog for 17bd55d037a02 is >>> pretty handwavy - do we know that deleting these things would make a >>> jot of difference? >> >> Really? I thought it was pretty decent ;) >> >> Anyway, xfstests 204, "Test out ENOSPC flushing on small filesystems." >> shows the problem clearly, IIRC. I should have included that in the >> changelog, I suppose, sorry. > > Your email didn't really impart any information :( > > I suppose I could accidentally delete those nasty little functions in a > drivers/parport patch then wait and see if anyone notices. > Um, ok, then, to answer the question directly : No, please don't delete those functions, it will break ENOSPC handling in ext4 as shown by xfstests regression test #204 ... -Eric