From: Lukas Czerner Subject: Re: [PATCH 11/15] mke2fs: fix determination of size_type Date: Tue, 30 Nov 2010 13:33:37 +0100 (CET) Message-ID: References: <1291020917-8671-1-git-send-email-namhyung@gmail.com> <1291020917-8671-12-git-send-email-namhyung@gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Theodore Tso , linux-ext4@vger.kernel.org To: Namhyung Kim Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58546 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754Ab0K3Mdl (ORCPT ); Tue, 30 Nov 2010 07:33:41 -0500 In-Reply-To: <1291020917-8671-12-git-send-email-namhyung@gmail.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, 29 Nov 2010, Namhyung Kim wrote: > In original code, 'huge' type could not be selected because it > always be caught for 'big' type. Change the ordering. > > Signed-off-by: Namhyung Kim > --- > misc/mke2fs.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/misc/mke2fs.c b/misc/mke2fs.c > index 90cc206..b88decf 100644 > --- a/misc/mke2fs.c > +++ b/misc/mke2fs.c > @@ -947,10 +947,10 @@ static char **parse_fs_type(const char *fs_type, > size_type = "floppy"; > else if (fs_blocks_count < 512 * meg) > size_type = "small"; > - else if (fs_blocks_count >= 4 * 1024 * 1024 * meg) > - size_type = "big"; > else if (fs_blocks_count >= 16 * 1024 * 1024 * meg) > size_type = "huge"; > + else if (fs_blocks_count >= 4 * 1024 * 1024 * meg) > + size_type = "big"; > else > size_type = "default"; > > Personally, I do not like it very much. Either sort this in ascending order and use "<" or sort it in descending order and use ">=". But since it was originally sorted in ascending order I would do that this way. -Lukas