From: Lukas Czerner Subject: Re: [PATCH] ext3: Remove redundant unlikely() Date: Thu, 9 Dec 2010 16:53:38 +0100 (CET) Message-ID: References: <1291905574-32355-1-git-send-email-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org To: Tobias Klauser Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61091 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754267Ab0LIPyQ (ORCPT ); Thu, 9 Dec 2010 10:54:16 -0500 In-Reply-To: <1291905574-32355-1-git-send-email-tklauser@distanz.ch> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, 9 Dec 2010, Tobias Klauser wrote: > IS_ERR() already implies unlikely(), so it can be omitted here. > > Signed-off-by: Tobias Klauser > --- > fs/ext3/namei.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c > index bce9dce..268f776 100644 > --- a/fs/ext3/namei.c > +++ b/fs/ext3/namei.c > @@ -1047,7 +1047,7 @@ static struct dentry *ext3_lookup(struct inode * dir, struct dentry *dentry, str > return ERR_PTR(-EIO); > } > inode = ext3_iget(dir->i_sb, ino); > - if (unlikely(IS_ERR(inode))) { > + if (IS_ERR(inode)) { > if (PTR_ERR(inode) == -ESTALE) { > ext3_error(dir->i_sb, __func__, > "deleted inode referenced: %lu", > Good catch, but I guess the same thing may be done for ext2/4. Thanks! -Lukas