From: Lukas Czerner Subject: Re: [PATCH] ext3: Remove redundant unlikely() Date: Thu, 9 Dec 2010 17:05:40 +0100 (CET) Message-ID: References: <1291905574-32355-1-git-send-email-tklauser@distanz.ch> <20101209160117.GG10190@distanz.ch> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Lukas Czerner , Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org To: Tobias Klauser Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46469 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859Ab0LIQGZ (ORCPT ); Thu, 9 Dec 2010 11:06:25 -0500 In-Reply-To: <20101209160117.GG10190@distanz.ch> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, 9 Dec 2010, Tobias Klauser wrote: > On 2010-12-09 at 16:53:38 +0100, Lukas Czerner wrote: > > On Thu, 9 Dec 2010, Tobias Klauser wrote: > > > > > IS_ERR() already implies unlikely(), so it can be omitted here. > > > > > > Signed-off-by: Tobias Klauser > > > --- > > > fs/ext3/namei.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c > > > index bce9dce..268f776 100644 > > > --- a/fs/ext3/namei.c > > > +++ b/fs/ext3/namei.c > > > @@ -1047,7 +1047,7 @@ static struct dentry *ext3_lookup(struct inode * dir, struct dentry *dentry, str > > > return ERR_PTR(-EIO); > > > } > > > inode = ext3_iget(dir->i_sb, ino); > > > - if (unlikely(IS_ERR(inode))) { > > > + if (IS_ERR(inode)) { > > > if (PTR_ERR(inode) == -ESTALE) { > > > ext3_error(dir->i_sb, __func__, > > > "deleted inode referenced: %lu", > > > > > > > Good catch, but I guess the same thing may be done for ext2/4. > > I did so actually [0], [1]. Unfortunately I didn't submit the three patches as a > series. > > [0] http://lists.openwall.net/linux-ext4/2010/12/09/6 > [1] http://lists.openwall.net/linux-ext4/2010/12/09/5 > > Cheers > Tobias > Ok, my apologize. I saw only this one on the ext4 list. -Lukas