From: Matt Subject: Re: hunt for 2.6.37 dm-crypt+ext4 corruption? (was: Re: dm-crypt barrier support is effective) Date: Wed, 15 Dec 2010 20:15:18 +0100 Message-ID: References: <20101210023852.GB3059@thunk.org> <20101212023415.GG3059@thunk.org> <20101212124354.GA4513@thunk.org> <20101213020657.GB4513@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jon Nelson , Chris Mason , Andi Kleen , Mike Snitzer , Milan Broz , linux-btrfs , dm-devel , Linux Kernel , htd , htejun , linux-ext4 To: "Ted Ts'o" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Mon, Dec 13, 2010 at 7:56 PM, Jon Nelson wrote= : > On Sun, Dec 12, 2010 at 8:06 PM, Ted Ts'o wrote: >> On Sun, Dec 12, 2010 at 07:11:28AM -0600, Jon Nelson wrote: >>> I'm glad you've been able to reproduce the problem! If you should n= eed >>> any further assistance, please do not hesitate to ask. >> >> This patch seems to fix the problem for me. =A0(Unless the partition= is >> mounted with mblk_io_submit.) >> >> Could you confirm that it fixes it for you as well? > > I believe I have applied the (relevant) inode.c changes to > bd2d0210cf22f2bd0cef72eb97cf94fc7d31d8cc, rebuilt and begun testing. > Now at 28 passes without error, I think I can say that the patch > appears to resolve the issue. > > -- > Jon > Confirmed ! I'm running my box for 5+ hours right now with your patch applied in addition to Andi's/Milan's patch (http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/= dm-crypt-scale-to-multiple-CPUs.patch) , Ted, and can't see any indications of corruptions so far (while doing an emerge -e system) and doing everyday stuff. My /home partition (with ext4) is also still intact [which of course has a backup] so it seems to fix it for me, too so the corruption I was seeing was similar in a way to that of Jon You can add a Tested-by: Matthias Bayer Thanks a lot to everyone for your support ! :) I have a question though: the deactivation of multiple page-io submission support most likely only would affect bigger systems or also desktop systems (like mine) ? Regards Matt