From: Roman Borisov Subject: Re: [PATCH] ext4: fix typo in ext4_find_entry() Date: Thu, 16 Dec 2010 16:41:13 +0300 Message-ID: <4D0A16F9.9000503@nokia.com> References: <1291826002-24989-1-git-send-email-aaro.koskinen@nokia.com> <4CFFC609.1090506@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Aaro Koskinen , tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, ext-phil.2.carmody@nokia.com To: ext Eric Sandeen , jack@suse.cz Return-path: Received: from mx04.teleca.com ([212.92.145.6]:37844 "EHLO mx04.teleca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857Ab0LPNq0 (ORCPT ); Thu, 16 Dec 2010 08:46:26 -0500 In-Reply-To: <4CFFC609.1090506@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 12/08/2010 08:53 PM, ext Eric Sandeen wrote: > On 12/08/2010 10:33 AM, Aaro Koskinen wrote: >> There should be a check for NUL character instead of '0'. >> >> Reported-by: Phil Carmody >> Signed-off-by: Aaro Koskinen >> --- >> fs/ext4/namei.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c >> index 92203b8..dc40e75 100644 >> --- a/fs/ext4/namei.c >> +++ b/fs/ext4/namei.c >> @@ -872,7 +872,7 @@ static struct buffer_head * ext4_find_entry (struct inode *dir, >> if (namelen> EXT4_NAME_LEN) >> return NULL; >> if ((namelen<= 2)&& (name[0] == '.')&& >> - (name[1] == '.' || name[1] == '0')) { >> + (name[1] == '.' || name[1] == '\0')) { >> /* >> * "." or ".." will only be in the first block >> * NFS may look up ".."; "." should be handled by the VFS > > Yep, as it was reviewed on the list when originally sent, oops! ;) > > -Eric Hi, the same fix should be done for ext3 patch which is planned to be in mainline: http://www.spinics.net/lists/linux-ext4/msg21215.html Roman