From: Manish Katiyar Subject: Re: [PATCH] ext4: Fix missing iput for root inode in case of all failed mount paths. Date: Sat, 26 Feb 2011 13:35:05 -0800 Message-ID: References: <032DF412-6B37-4EB7-A687-8216CB1E2BAB@dilger.ca> <20110207232343.GA26289@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Andreas Dilger , ext4 To: "Ted Ts'o" Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:42904 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab1BZVf0 (ORCPT ); Sat, 26 Feb 2011 16:35:26 -0500 Received: by qyk7 with SMTP id 7so1315926qyk.19 for ; Sat, 26 Feb 2011 13:35:25 -0800 (PST) In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, Feb 7, 2011 at 3:31 PM, Manish Katiyar wrote: > On Mon, Feb 7, 2011 at 3:23 PM, Ted Ts'o wrote: >> On Sat, Jan 29, 2011 at 09:40:34PM -0800, Manish Katiyar wrote: >>> >>> Any feedback on this ? >> >> The patch looks good, but it doesn't fix bug #26752. >> >> The root cause of that bug is the fact that ext4_sync_fs() and >> ext4_put_super() assumes that sbi has been initialized. Hi Ted, Is there anything else that I need to do to get this merged in your tree ? > > Hmm.. Actually I was looking at generic_super_shutdown() which I > thought would call ext4_put_super() only if sb->root is set, and since > I was setting sb->root explicitly to NULL in my patch in case of > failures. > > -- > Thanks - > Manish > -- Thanks - Manish