From: Jan Kara Subject: Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses Date: Tue, 10 May 2011 19:03:07 +0200 Message-ID: <20110510170307.GO4402@quack.suse.cz> References: <20110509230318.19566.66202.stgit@elm3c44.beaverton.ibm.com> <87tyd31fkc.fsf@devron.myhome.or.jp> <20110510133603.GA5823@infradead.org> <874o524q9h.fsf@devron.myhome.or.jp> <20110510144939.GI4402@quack.suse.cz> <87aaeur31x.fsf@devron.myhome.or.jp> <20110510161836.GL4402@quack.suse.cz> <87r586plhz.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Christoph Hellwig , "Darrick J. Wong" , Theodore Tso , Alexander Viro , Jens Axboe , "Martin K. Petersen" , Jeff Layton , Dave Chinner , linux-kernel , Dave Hansen , linux-mm@kvack.org, Chris Mason , Joel Becker , linux-scsi , linux-fsdevel , linux-ext4@vger.kernel.org, Mingming Cao To: OGAWA Hirofumi Return-path: Content-Disposition: inline In-Reply-To: <87r586plhz.fsf@devron.myhome.or.jp> Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Wed 11-05-11 01:29:28, OGAWA Hirofumi wrote: > Jan Kara writes: > > > On Wed 11-05-11 00:24:58, OGAWA Hirofumi wrote: > >> Jan Kara writes: > >> > >> >> Isn't it reallocated blocks too, and metadata too? > >> > Reallocated blocks - not really. For a block to be freed it cannot be > >> > under writeback and when it's freed no writeback is started. > >> > >> Sure for data -> data reallocated case. metadata -> data/metadata is > >> still there. > > Unless you properly use bforget() (which you should I think). But I have > > not really checked this in detail for a while. > > bforget() doesn't wait IO, right? Right, my fault. Sorry. So you were right, reallocated blocks will be hit as well. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org