From: H Hartley Sweeten Subject: [PATCH] ext3/ioctl.c: quite sparse warnings about different address spaces Date: Fri, 10 Jun 2011 14:59:05 -0700 Message-ID: <201106101459.06129.hartleys@visionengravers.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , , , To: Linux Kernel Return-path: Received: from mail209.messagelabs.com ([216.82.255.3]:3077 "EHLO mail209.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754736Ab1FJV7U (ORCPT ); Fri, 10 Jun 2011 17:59:20 -0400 Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: The 'from' argument for copy_from_user and the 'to' argument for copy_to_user should both be tagged as __user address space. Signed-off-by: H Hartley Sweeten Cc: Jan Kara Cc: Andrew Morton Cc: Andreas Dilger --- diff --git a/fs/ext3/ioctl.c b/fs/ext3/ioctl.c index f4090bd..c7f4394 100644 --- a/fs/ext3/ioctl.c +++ b/fs/ext3/ioctl.c @@ -285,7 +285,7 @@ group_add_out: if (!capable(CAP_SYS_ADMIN)) return -EPERM; - if (copy_from_user(&range, (struct fstrim_range *)arg, + if (copy_from_user(&range, (struct fstrim_range __user *)arg, sizeof(range))) return -EFAULT; @@ -293,7 +293,7 @@ group_add_out: if (ret < 0) return ret; - if (copy_to_user((struct fstrim_range *)arg, &range, + if (copy_to_user((struct fstrim_range __user *)arg, &range, sizeof(range))) return -EFAULT;