From: Andreas Dilger Subject: Re: Commit 94968e74 breaks f_lotsbad Date: Wed, 29 Jun 2011 01:09:10 -0600 Message-ID: <5A29A018-F7A0-45C6-B77F-143BE5D1F116@whamcloud.com> References: <418F4E42-50E6-4CAA-B6F5-CA59B17E84C0@whamcloud.com> <20110620015801.GB32133@thunk.org> <574FA1C6-62AF-4AF0-B43C-415923D63BB1@whamcloud.com> <20110628142350.GI2729@thunk.org> Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Cc: ext4 development To: Ted Ts'o Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:38174 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097Ab1F2HJO convert rfc822-to-8bit (ORCPT ); Wed, 29 Jun 2011 03:09:14 -0400 Received: by pwj7 with SMTP id 7so640880pwj.19 for ; Wed, 29 Jun 2011 00:09:13 -0700 (PDT) In-Reply-To: <20110628142350.GI2729@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 2011-06-28, at 8:23 AM, Ted Ts'o wrote: > On Mon, Jun 27, 2011 at 11:16:14PM -0600, Andreas Dilger wrote: >> >> I retested after pulling your commit 1ca87790b914a1958f3cbd8b5e1e7037f2cf30ed >> "libext2fs: fix makefile dependency problem", but even when I do "make clean" >> before each test I still get a failure on the "f_lotsbad" test: > > I can't replicate this problem on my end. What gcc version are you > using, and what are your configure options? > > This is what I'm using > > % ./config.status --version > config.status > configured by ../configure, generated by GNU Autoconf 2.65, > with options "'--enable-elf-shlibs' '--enable-maintainer-mode' 'CFLAGS=-g' '--enable-symlink-build' '--enable-symlink-install' '--disable-libuuid' '--disable-libblkid'" > > Copyright (C) 2009 Free Software Foundation, Inc. > This config.status script is free software; the Free Software Foundation > gives unlimited permission to copy, distribute and modify it. > > % gcc --version > gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 I'm testing on an FC13 system, with a downgraded 2.6.32 FC12 kernel: [root@sookie e2fsprogs-git]# git describe v1.41.14-228-g1ca8779 [root@sookie e2fsprogs-git]# git diff [root@sookie e2fsprogs-git]# ./config.status --version config.status configured by ./configure, generated by GNU Autoconf 2.65, with options "" Copyright (C) 2009 Free Software Foundation, Inc. This config.status script is free software; the Free Software Foundation gives unlimited permission to copy, distribute and modify it. [root@sookie e2fsprogs-git]# gcc --version gcc (GCC) 4.4.5 20101112 (Red Hat 4.4.5-2) Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [root@sookie e2fsprogs-git]# cd tests [root@sookie tests]# make test_script /bin/cp ./mke2fs.conf.in mke2fs.conf Creating test_script... [root@sookie tests]# ./test_script f_lotsbad f_lotsbad: too many illegal blocks in inode: failed 0 tests succeeded 1 tests failed Very strangely, the test passes on another node (older FC3 with many updates) when run as a non-root user, though this isn't true on the original test node: [adilger@mookie tests]$ ./test_script f_lotsbad f_lotsbad: too many illegal blocks in inode: ok 1 tests succeeded 0 tests failed [adilger@mookie tests]$ logout [root@mookie e2fsprogs-git]# cd tests/ [root@mookie tests]# ./test_script f_lotsbad f_lotsbad: too many illegal blocks in inode: failed 0 tests succeeded 1 tests failed root@mookie tests]# su adilger Agent pid 29339 [adilger@mookie tests]$ ./test_script f_lotsbad f_lotsbad: too many illegal blocks in inode: ok 1 tests succeeded 0 tests failed [adilger@mookie tests]$ ./config.status --version config.status configured by ./configure, generated by GNU Autoconf 2.65, with options "'CFLAGS=-Wall -g'" Copyright (C) 2009 Free Software Foundation, Inc. This config.status script is free software; the Free Software Foundation gives unlimited permission to copy, distribute and modify it. [adilger@mookie tests]$ gcc -V gcc: `-V' option must have argument [adilger@mookie tests]$ gcc --version gcc (GCC) 3.4.4 20050721 (Red Hat 3.4.4-2) Copyright (C) 2004 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Comparing the environments between user and root don't show any (apparently) significant differences (PATH is different, but I don't think this test uses anything outside the local e2fsck) and even running strace the only noticeable differences are the getuid/getgid calls, and umask (which impacts the mode on the test.img file, but I don't think that should be relevant either). Cheers, Andreas -- Andreas Dilger Principal Engineer Whamcloud, Inc.