From: Ted Ts'o Subject: Re: [PATCH v2] ext4: Deprecate data=journal mount option Date: Sat, 13 Aug 2011 22:06:17 -0400 Message-ID: <20110814020617.GB3524@thunk.org> References: <1309260363-19012-1-git-send-email-lczerner@redhat.com> <4E44E374.7080103@redhat.com> <20110812181330.GG31181@thunk.org> <20110812205719.GA1670@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Lukas Czerner , Curt Wohlgemuth , Ric Wheeler , Andreas Dilger , linux-ext4 List , Jan Kara , Eric Sandeen To: Christoph Hellwig Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:47624 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272Ab1HNCG2 (ORCPT ); Sat, 13 Aug 2011 22:06:28 -0400 Content-Disposition: inline In-Reply-To: <20110812205719.GA1670@infradead.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, Aug 12, 2011 at 04:57:19PM -0400, Christoph Hellwig wrote: > > and differences in error code returns for > > xattrs) and #79 (a failure in the append-only handling which I don't > > completely understand yet). > > This was discussed on fsdevel lately. All filesystem but xfs inherit > the append only bit from directories to files created inside them. > This not only is not very useful behaviour, but also exposes a bug > in the vfs that allows to create these new files, but fail the open > unless using O_APPEND which is against the posix create semantics. I agree that disabling inheritance of the APPEND_FL flag makes sense. I propose we do this for ext2/3/4 and any other file systems which is currently following the ext2/3/4 behavior. Any objections? - Ted