From: Li Haifeng Subject: Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode() Date: Tue, 30 Aug 2011 19:29:29 +0800 Message-ID: References: <20110830103545.GA16202@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org To: linux-ext4@vger.kernel.org Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:61127 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044Ab1H3L3a convert rfc822-to-8bit (ORCPT ); Tue, 30 Aug 2011 07:29:30 -0400 In-Reply-To: <20110830103545.GA16202@quack.suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: Thanks for your point. I will remake this patch. 2011/8/30 Jan Kara > > On Tue 30-08-11 17:53:58, Li Haifeng wrote: > > The function iget =A0referred by the comment is replaced by ext2_ig= et . > > And the ext2_read_inode() is not exist, the ext2_iget is "neater". = So > > the comment is fixed here. > > > > Signed-off-by: Li Haifeng > > --- > > =A0fs/ext2/super.c | =A0 =A06 ++---- > > =A01 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > > index 1dd62ed..994ced3 100644 > > --- a/fs/ext2/super.c > > +++ b/fs/ext2/super.c > > @@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct > > super_block *sb, > > =A0 =A0 if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count)) > > =A0 =A0 =A0 =A0 return ERR_PTR(-ESTALE); > > > > - =A0 /* iget isn't really right if the inode is currently unalloca= ted!! > > - =A0 =A0* ext2_read_inode currently does appropriate checks, but > > - =A0 =A0* it might be "neater" to call ext2_get_inode first and ch= eck > > - =A0 =A0* if the inode is valid..... > > + =A0 /* > > + =A0 =A0* ext2_iget isn't really right if the inode is currently u= nallocated!! > =A0OK, but we should keep there a note that ext2_iget() does appropri= ate > checks to handle stale inodes. > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= Honza > > =A0 =A0 =A0*/ > > =A0 =A0 inode =3D ext2_iget(sb, ino); > > =A0 =A0 if (IS_ERR(inode)) > > -- > > 1.7.4.1 > -- > Jan Kara > SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html