From: Ted Ts'o Subject: Re: [PATCH 1/2] libext2fs: add metadata checksum and snapshot feature flags Date: Thu, 15 Sep 2011 19:11:27 -0400 Message-ID: <20110915231127.GK28181@thunk.org> References: <1316127052-1890-1-git-send-email-tytso@mit.edu> <1316127052-1890-2-git-send-email-tytso@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ext4 Developers List , "Darrick J. Wong" , Amir Goldstein To: Andreas Dilger Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:50516 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935246Ab1IOXLa (ORCPT ); Thu, 15 Sep 2011 19:11:30 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Sep 15, 2011 at 05:09:13PM -0600, Andreas Dilger wrote: > > I thought it would be better to move s_checksum to be the last field in the > superblock to avoid multiple calls to the CRC function? Did you see my comment about just zero'ing the checksum field before running the CRC? We're going to have to do that for other data structures, such as the inode structure, and it's what we do with the block group descriptor checksum. Might as well do that everywhere for consistency's sake. - Ted