From: "Darrick J. Wong" <djwong@us.ibm.com>
Subject: [PATCH] e2fsck: When restarting fsck on account of MMP, zero
	ctx->fs after fs is freed
Date: Fri, 30 Sep 2011 12:40:05 -0700
Message-ID: <20110930194005.GT12086@tux1.beaverton.ibm.com>
Reply-To: djwong@us.ibm.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Content-Disposition: inline
Sender: linux-ext4-owner@vger.kernel.org

If MMP is enabled and e2fsck determines that it needs to restart itself on
account of various MMP conditions, it will close the current fs and jump back
to the start of fs checking.  However, closing fs also frees it, which means
that we need to set ctx->fs to NULL to prevent subsequent open code from
accessing the old deleted pointer.

(This fix came up while testing the metadata checksumming patchset)

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---

 e2fsck/unix.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/e2fsck/unix.c b/e2fsck/unix.c
index f980962..37cfb00 100644
--- a/e2fsck/unix.c
+++ b/e2fsck/unix.c
@@ -1351,6 +1351,7 @@ failure:
 	  * Restart in order to reopen fs but this time start mmp.
 	  */
 	if (flags & EXT2_FLAG_SKIP_MMP) {
+		ctx->fs = NULL;
 		ext2fs_close(fs);
 		flags &= ~EXT2_FLAG_SKIP_MMP;
 		goto restart;