From: Ted Ts'o Subject: Re: [BUG] copy file result with zero Date: Mon, 3 Oct 2011 10:18:23 -0400 Message-ID: <20111003141823.GA6684@thunk.org> References: <20111001143900.GH28234@thunk.org> <89E75765-AC24-4EF4-9547-6EE7A1A38B5A@dilger.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Yongqiang Yang , Andreas Dilger , Jeff liu , Dave Young , Linux Kernel Mailing List , linux-ext4@vger.kernel.org To: Lukas Czerner Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:56779 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611Ab1JCOSa (ORCPT ); Mon, 3 Oct 2011 10:18:30 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, Oct 03, 2011 at 03:11:30PM +0200, Lukas Czerner wrote: > > Oops, you're right. I think that the best solution would be to revert > the commit > > c03f8aa9abdd517477c2021ea1251939b4da49e6 > ext4: use FIEMAP_EXTENT_LAST flag for last extent in fiemap > > and then fix the original problem with your delayed extent tree > solution, where we can easily check not only for next allocated extent, > but also for next delayed extent to see if the current one is last or > not. > ... > > I do not know how "ready" are your patches..Is it possible to wait for > them to be ready and fix it in your patch set ? That means, revert the > mentioned commit and reimplement fiemap with delayed extent tree. Sigh, yeah, we need to fix this to avoid the hang in xfstests #252 but users losing data even if the coreutils release was only out there for 13 days is bad juju. I'm working on reviewing the kernel patch backlog this week, and I'll give this series one priority. Thanks to Yongqiang and Lukas for looking into this! - Ted