From: Jan Kara Subject: Re: [PATCH] ext3/balloc.c: local functions should be static Date: Wed, 5 Oct 2011 01:29:58 +0200 Message-ID: <20111004232958.GA21205@quack.suse.cz> References: <201109231355.52431.hartleys@visionengravers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel , linux-ext4@vger.kernel.org, jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca To: H Hartley Sweeten Return-path: Received: from cantor2.suse.de ([195.135.220.15]:39064 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933677Ab1JDXaA (ORCPT ); Tue, 4 Oct 2011 19:30:00 -0400 Content-Disposition: inline In-Reply-To: <201109231355.52431.hartleys@visionengravers.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri 23-09-11 13:55:52, H Hartley Sweeten wrote: > This quites the sparse noise: > > warning: symbol 'ext3_trim_all_free' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten > Cc: Jan Kara > Cc: Andrew Morton > Cc: Andreas Dilger Thanks, merged into my tree. Honza > > --- > > diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c > index 6386d76..8e62ec5 100644 > --- a/fs/ext3/balloc.c > +++ b/fs/ext3/balloc.c > @@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group) > * reaches any used block. Then issue a TRIM command on this extent and free > * the extent in the block bitmap. This is done until whole group is scanned. > */ > -ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group, > - ext3_grpblk_t start, ext3_grpblk_t max, > - ext3_grpblk_t minblocks) > +static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, > + unsigned int group, > + ext3_grpblk_t start, ext3_grpblk_t max, > + ext3_grpblk_t minblocks) > { > handle_t *handle; > ext3_grpblk_t next, free_blocks, bit, freed, count = 0; -- Jan Kara SUSE Labs, CR