From: Jan Kara Subject: Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static Date: Wed, 5 Oct 2011 22:18:16 +0200 Message-ID: <20111005201816.GJ23467@quack.suse.cz> References: <201109231507.09998.hartleys@visionengravers.com> <20111004233746.GC21205@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Linux Kernel , "linux-ext4@vger.kernel.org" , "akpm@linux-foundation.org" , "adilger.kernel@dilger.ca" To: H Hartley Sweeten Return-path: Received: from cantor2.suse.de ([195.135.220.15]:41433 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935179Ab1JEUSR (ORCPT ); Wed, 5 Oct 2011 16:18:17 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed 05-10-11 12:27:06, H Hartley Sweeten wrote: > On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote: > > On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote: > >> Quiets the sparse noise: > >> > >> warning: symbol 'ext3_initxattrs' was not declared. Should it be static? > >> > >> Signed-off-by: H Hartley Sweeten > >> Cc: Jan Kara > >> Cc: Andrew Morton > >> Cc: Andreas Dilger > > Here applies the same comment as to the ext2 patch - not in current > > Linus' kernel AFAICS. > > These are in linux-next due to: > > commit 9d8f13ba3f4833219e50767b022b82cd0da930eb > Author: Mimi Zohar > Date: Mon Jun 6 15:29:25 2011 -0400 > > security: new security_inode_init_security API adds function callback > > I can repost these after this commit hits Linus' kernel if necessary. I see. OK, please repost when they hit Linus' kernel since I guess it's not urgent to merge these. Honza -- Jan Kara SUSE Labs, CR