From: Andreas Dilger Subject: Re: [PATCH 12/28] ext4: Use i_generation in inode-related metadata checksums Date: Wed, 12 Oct 2011 18:06:43 -0600 Message-ID: References: <20111008075343.20506.23155.stgit@elm3c44.beaverton.ibm.com> <20111008075502.20506.15728.stgit@elm3c44.beaverton.ibm.com> <20111012212838.GP12447@tux1.beaverton.ibm.com> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Theodore Tso , Sunil Mushran , Martin K Petersen , Greg Freemyer , Amir Goldstein , linux-kernel , Andi Kleen , Mingming Cao , Joel Becker , linux-fsdevel , linux-ext4@vger.kernel.org, Coly Li To: djwong@us.ibm.com Return-path: Received: from idcmail-mo2no.shaw.ca ([64.59.134.9]:55722 "EHLO idcmail-mo2no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959Ab1JMAFu (ORCPT ); Wed, 12 Oct 2011 20:05:50 -0400 In-Reply-To: <20111012212838.GP12447@tux1.beaverton.ibm.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 2011-10-12, at 3:28 PM, Darrick J. Wong wrote: > On Wed, Oct 12, 2011 at 12:52:30PM -0700, Andreas Dilger wrote: >> On 2011-10-08, at 12:55 AM, Darrick J. Wong wrote: >>> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c >>> index f18bfe3..fdf0b1e 100644 >>> --- a/fs/ext4/ioctl.c >>> +++ b/fs/ext4/ioctl.c >>> @@ -149,6 +149,10 @@ flags_out: >>> if (!inode_owner_or_capable(inode)) >>> return -EPERM; >>> >>> + if (EXT4_HAS_RO_COMPAT_FEATURE(inode->i_sb, >>> + EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) >>> + return -ENOTTY; >> >> This should get an ext4_warning() in the non-checksum case to warn >> users that this ioctl is deprecated and will be removed in the >> future unless there is a good reason to keep it. > > Ok. Maybe put it in feature_removal_schedule.txt too? Maybe not; the > ioctl is not being totally removed, it's merely unsupported for the > metadata_csum case. I understand it is not being removed entirely, but since it doesn't work at all with the checksum-enabled case, we may as well mark it deprecated for the non-checksum case to allow us to catch any users (however unlikely I think it is) earlier rather than later. Cheers, Andreas