From: Eric Sandeen Subject: Re: [PATCH 2/5 resend] Thaw the journal when you unfreeze the fs. Date: Tue, 06 Dec 2011 10:22:58 -0600 Message-ID: <4EDE4162.3070200@redhat.com> References: <1323118489-16326-1-git-send-email-kamal@canonical.com> <1323118489-16326-3-git-send-email-kamal@canonical.com> <1323169644.4838.13.camel@mfleming-mobl1.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Kamal Mostafa , Jan Kara , Alexander Viro , Andreas Dilger , Matthew Wilcox , Randy Dunlap , Theodore Tso , linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Surbhi Palande , Valerie Aurora , Christopher Chaltain , "Peter M. Petrakis" , Mikulas Patocka , Surbhi Palande To: Matt Fleming Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7793 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028Ab1LFQXl (ORCPT ); Tue, 6 Dec 2011 11:23:41 -0500 In-Reply-To: <1323169644.4838.13.camel@mfleming-mobl1.ger.corp.intel.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 12/6/11 5:07 AM, Matt Fleming wrote: > On Mon, 2011-12-05 at 12:54 -0800, Kamal Mostafa wrote: >> From: Surbhi Palande >> >> Thaw the journal so that transactions can resume >> >> BugLink: https://bugs.launchpad.net/bugs/897421 >> Signed-off-by: Surbhi Palande >> Cc: Kamal Mostafa >> Tested-by: Peter M. Petrakis >> Signed-off-by: Kamal Mostafa >> --- >> fs/ext4/super.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) > > Shouldn't this patch really be merged with [PATCH 1/5] ? Otherwise it's > possible to freeze a journal that will never be unfrozen, if say, you're > doing a git bisect and you have [PATCH 1/5] applied but not [PATCH 2/5]. I second that; I was going to send the same comment but you beat me to it. Doing it this way will make it a tough go when bisecting freeze issues, it needs to be rolled into patch 1. Thanks, -Eric