From: Ted Ts'o Subject: Re: [PATCH] ext4: Support "check=none" "nocheck" mount options Date: Wed, 11 Jan 2012 10:26:46 -0500 Message-ID: <20120111152646.GB4589@thunk.org> References: <20120110174118.GB3015@zod.bos.redhat.com> <4F0C78CD.6070809@redhat.com> <7A0721E1-689F-4B9B-BD8C-86A03DDF20CE@dilger.ca> <4F0DA724.2040506@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andreas Dilger , Josh Boyer , linux-ext4@vger.kernel.org, kernel-team@fedoraproject.org To: Eric Sandeen Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:56944 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755380Ab2AKP0y (ORCPT ); Wed, 11 Jan 2012 10:26:54 -0500 Content-Disposition: inline In-Reply-To: <4F0DA724.2040506@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Jan 11, 2012 at 09:13:40AM -0600, Eric Sandeen wrote: > > In any case, I can't imagine why a user would have this set for a kernel > > option that might have last been valid 10 years ago, and why the 5 users > > in the world that might have this set cannot simply remove it from their > > fstab, since it does absolutely nothing? > > Well, I agree that it should be deprecated, but that's a separate issue from > making ext4 handle all current ext2/3 mount options. > > Let's just push this one in, and can do another patch to add the dire > deprecation warnings to all filesystems, ok? Then in 5 more years we can > remember to remove it ;) If we're going to deprecate it, we should deprecate it for *all* of the ext 2/3/4 file systems. Otherwise let's not bother, and keep the no-op for backwards compatibility. If we are going to support ext4 taking over for ext2/3, then yes we need to support any common mount options, and if we want to deprecate a particular option in ext4, we should try to deprecate them in ext2/3 as well. - Ted