From: Linus Torvalds Subject: Re: [RFC PATCH 0/3] Stop clearing uptodate flag on write IO error Date: Sat, 14 Jan 2012 18:19:02 -0800 Message-ID: References: <1325774407-28531-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Andrew Morton , Christoph Hellwig , Al Viro , LKML , Edward Shishkin To: Jan Kara Return-path: Received: from mail-ww0-f42.google.com ([74.125.82.42]:43912 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437Ab2AOCTZ convert rfc822-to-8bit (ORCPT ); Sat, 14 Jan 2012 21:19:25 -0500 In-Reply-To: <1325774407-28531-1-git-send-email-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Jan 5, 2012 at 6:40 AM, Jan Kara wrote: > > =A0for mostly historical reasons we still clear buffer_uptodate flag = on write > IO errors. This is not only semantically wrong (buffer still has corr= ect data > in it) That statement is so nonsensical that I can't get past it. When you understand why it is nonsensical, you understand why the bit is cleared. =46eel free to bring this up again without that idiotic statement as an= argument. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html