From: Dave Chinner Subject: Re: [RFC PATCH 0/3] Stop clearing uptodate flag on write IO error Date: Tue, 24 Jan 2012 11:36:57 +1100 Message-ID: <20120124003657.GJ15102@dastard> References: <1325774407-28531-1-git-send-email-jack@suse.cz> <20120116160136.GC16431@quack.suse.cz> <20120117003613.GA28571@dastard> <20120123030422.GE15102@dastard> <20120123214709.GB17974@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Ted Ts'o , Linus Torvalds , Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Andrew Morton , Christoph Hellwig , Al Viro , LKML , Edward Shishkin Return-path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:42045 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443Ab2AXAhB (ORCPT ); Mon, 23 Jan 2012 19:37:01 -0500 Content-Disposition: inline In-Reply-To: <20120123214709.GB17974@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, Jan 23, 2012 at 04:47:09PM -0500, Ted Ts'o wrote: > > The thing is, transient write errors tend to be isolated and go away > > when a retry occurs (think of IO timeouts when multipath failover > > occurs). When non-isolated IO or unrecoverable problems occur (e.g. > > no paths left to fail over onto), critical other metadata reads and > > writes will fail and shut down the filesystem, thereby terminating > > the "try forever" background writeback loop those delayed write > > buffers may be in. So the truth is that "trying forever" on write > > errors can handle a whole class of write IO errors very > > effectively.... > > So how does XFS decide whether a write should fail and shutdown the > file system, or just "try forever"? The IO dispatcher decides that. If the dispatcher has handed the IO off to the delayed write queue, then failed writes will be tried again. If the caller is catching the IO completion (e.g. sync writes) or attaching a completion callback (journal IO), then the completion context will handle the error appropriately. Journal IO errors tend to shutdown the filesystem on the first error, other contexts may handle the error, retry or shutdown the filesystem depending on their current state when the error occurs. Reads are even more complex, because ithe dispatch context can be within a transaction and the correct error handling is then dependent on the current state of the transaction.... Cheers, Dave. -- Dave Chinner david@fromorbit.com