From: Ted Ts'o Subject: Re: [PATCH 1/1] ext4: Remove empty index blocks when punching holes Date: Tue, 6 Mar 2012 11:44:12 -0500 Message-ID: <20120306164412.GD32282@thunk.org> References: <1330501048-14109-1-git-send-email-achender@linux.vnet.ibm.com> <4F4DDE8D.6020203@linux.vnet.ibm.com> <20120305235430.GA12796@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Allison Henderson , linux-ext4@vger.kernel.org To: Lukas Czerner Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:48239 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264Ab2CFQoR (ORCPT ); Tue, 6 Mar 2012 11:44:17 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, Mar 06, 2012 at 08:11:37AM +0100, Lukas Czerner wrote: > > you're right my patches solves this problem (as I wrote in the commit > description) just because we now use a different code paths, which do > not have this problem. Ok, thanks. I'll look at them before the end of this week. Just to be clear, have the problematic code paths been removed in your patches, or are they not just being used in the problem scenario? Basically, is there any other time where we might need the additional logic which Allison added? - Ted