From: Joe Perches Subject: Re: [PATCH 1/9] ext4: Add -DDEBUG to Makefile Date: Mon, 19 Mar 2012 09:26:19 -0700 Message-ID: <1332174379.1983.14.camel@joe2Laptop> References: <7ee60f3b750f4500f9bdcb64f358acbf17987036.1331856300.git.joe@perches.com> <4F63646D.1040700@cavium.com> <20120319043937.GN31682@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Daney , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Ted Ts'o Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:60661 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1031218Ab2CSQ0U (ORCPT ); Mon, 19 Mar 2012 12:26:20 -0400 In-Reply-To: <20120319043937.GN31682@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, 2012-03-19 at 00:39 -0400, Ted Ts'o wrote: > So I've never considered it worthwhile to enable them via a CONFIG_* > menu item; developers who are debugging a specific problem will > generally just drop in the specific #define on an ad hoc basis, and > that works fine. CONFIG_EXT4_DEBUG_MASK=value and/or a module_param(debug) is possible to add but as Ted said, it's not really too valuable. dynamic_debugging the always compiled-in current KERN_DEBUG or eliminating them altogether might have some value though.