From: Jan Kara Subject: Re: [PATCH] ext2: do not register write_super within VFS Date: Wed, 4 Apr 2012 00:36:32 +0200 Message-ID: <20120403223632.GA5288@quack.suse.cz> References: <1333446558-28171-1-git-send-email-dedekind1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Ext4 Mailing List To: Artem Bityutskiy Return-path: Received: from cantor2.suse.de ([195.135.220.15]:60011 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352Ab2DCWgf (ORCPT ); Tue, 3 Apr 2012 18:36:35 -0400 Content-Disposition: inline In-Reply-To: <1333446558-28171-1-git-send-email-dedekind1@gmail.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue 03-04-12 12:49:18, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > Jan Kara removed 'sb->s_dirt' VFS flag references, so we do not need to > register the ext2 'ext2_write_super()' method in the VFS superblock operations, > because 'sb->s_dirt' won't be ever set to 1 and VFS won't ever call > '->write_super()' anyway. Thus, remove the method. > > Tested using xfstests. > > Signed-off-by: Artem Bityutskiy Thanks. Added to my tree. Honza > --- > fs/ext2/super.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index a43f9ad..e0e8f45 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -302,7 +302,6 @@ static const struct super_operations ext2_sops = { > .write_inode = ext2_write_inode, > .evict_inode = ext2_evict_inode, > .put_super = ext2_put_super, > - .write_super = ext2_write_super, > .sync_fs = ext2_sync_fs, > .statfs = ext2_statfs, > .remount_fs = ext2_remount, > -- > 1.7.7.6 > -- Jan Kara SUSE Labs, CR