From: Jeff Liu Subject: Re: [PATCH 10/12] container quota: bill container inodes alloc/free on ext4. Date: Thu, 31 May 2012 20:58:53 +0800 Message-ID: <4FC76B0D.6020804@oracle.com> References: <1338389946-13711-1-git-send-email-jeff.liu@oracle.com> <1338389946-13711-11-git-send-email-jeff.liu@oracle.com> <4FC736AD.2070404@parallels.com> Reply-To: jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jack-AlSwsSmVLrQ@public.gmane.org, Ted Ts'o , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, bpm-sJ/iWh9BUns@public.gmane.org, christopher.jones-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tm-d1IQDZat3X0@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, chris.mason-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, tinguely-sJ/iWh9BUns@public.gmane.org To: Glauber Costa Return-path: In-Reply-To: <4FC736AD.2070404-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-ext4.vger.kernel.org On 05/31/2012 05:15 PM, Glauber Costa wrote: > On 05/30/2012 06:59 PM, jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org wrote: >> +#include "../ns_quotaops.h" >> + >> /* >> * ialloc.c contains the inodes allocation and deallocation routines >> */ >> @@ -233,6 +235,7 @@ void ext4_free_inode(handle_t *handle, struct >> inode *inode) >> dquot_initialize(inode); >> ext4_xattr_delete_inode(handle, inode); >> dquot_free_inode(inode); >> + ns_dquot_free_inode(inode); >> dquot_drop(inode); > > This should be inside dquot_free_inode(). Yeah, Ted also mentioned this before, all name space dquot bill routine could be placed to dquot_xxx() for VFS quota user. However, AFAICS, they still have to be exported to other file systems which have their own quota management module, like XFS. Thanks, -Jeff > > No need to go patch inode.c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html