From: Andrew Morton Subject: Re: [RFC, PATCH, RESEND] fs: push rcu_barrier() from deactivate_locked_super() to filesystems Date: Fri, 8 Jun 2012 15:31:20 -0700 Message-ID: <20120608153120.b722d7c3.akpm@linux-foundation.org> References: <1339191663-17693-1-git-send-email-kirill.shutemov@linux.intel.com> <20120608150253.e42464a6.akpm@linux-foundation.org> <20120608221446.GA18250@otc-wbsnb-06> <20120608152550.258d6a30.akpm@linux-foundation.org> <20120608222734.GT30000@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Kirill A. Shutemov" , Linus Torvalds , Boaz Harrosh , Tao Ma , Nick Piggin , "Dmitry V. Levin" , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, codalist@TELEMANN.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, osd-dev@open-osd.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, logfs@logfs.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org To: Al Viro Return-path: In-Reply-To: <20120608222734.GT30000@ZenIV.linux.org.uk> Sender: ceph-devel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Fri, 8 Jun 2012 23:27:34 +0100 Al Viro wrote: > On Fri, Jun 08, 2012 at 03:25:50PM -0700, Andrew Morton wrote: > > > A neater implementation might be to add a kmem_cache* argument to > > unregister_filesystem(). If that is non-NULL, unregister_filesystem() > > does the rcu_barrier() and destroys the cache. That way we get to > > delete (rather than add) a bunch of code from all filesystems and new > > and out-of-tree filesystems cannot forget to perform the rcu_barrier(). > > There's often enough more than one cache, so that one is no-go. kmem_cache** ;) Which filesystems have multiple inode caches?