From: Jan Kara Subject: Re: [PATCHv6 4/5] ext4: weed out ext4_write_super Date: Wed, 11 Jul 2012 12:08:03 +0200 Message-ID: <20120711100803.GF1316@quack.suse.cz> References: <1342000698-13556-1-git-send-email-dedekind1@gmail.com> <1342000698-13556-5-git-send-email-dedekind1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Theodore Tso , Jan Kara , Linux FS Maling List , Linux Kernel Maling List , Ext4 Mailing List To: Artem Bityutskiy Return-path: Content-Disposition: inline In-Reply-To: <1342000698-13556-5-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Wed 11-07-12 12:58:17, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > We do not depend on VFS's '->write_super()' anymore and do not need the > 's_dirt' flag anymore, so weed out 'ext4_write_super()' and 's_dirt'. > > Signed-off-by: Artem Bityutskiy Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/super.c | 10 ---------- > 1 files changed, 0 insertions(+), 10 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index a391c53..622d5c7 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -74,7 +74,6 @@ static const char *ext4_decode_error(struct super_block *sb, int errno, > static int ext4_remount(struct super_block *sb, int *flags, char *data); > static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf); > static int ext4_unfreeze(struct super_block *sb); > -static void ext4_write_super(struct super_block *sb); > static int ext4_freeze(struct super_block *sb); > static struct dentry *ext4_mount(struct file_system_type *fs_type, int flags, > const char *dev_name, void *data); > @@ -1194,7 +1193,6 @@ static const struct super_operations ext4_nojournal_sops = { > .dirty_inode = ext4_dirty_inode, > .drop_inode = ext4_drop_inode, > .evict_inode = ext4_evict_inode, > - .write_super = ext4_write_super, > .put_super = ext4_put_super, > .statfs = ext4_statfs, > .remount_fs = ext4_remount, > @@ -4203,7 +4201,6 @@ static int ext4_commit_super(struct super_block *sb, int sync) > es->s_free_inodes_count = > cpu_to_le32(percpu_counter_sum_positive( > &EXT4_SB(sb)->s_freeinodes_counter)); > - sb->s_dirt = 0; > BUFFER_TRACE(sbh, "marking dirty"); > ext4_superblock_csum_set(sb, es); > mark_buffer_dirty(sbh); > @@ -4310,13 +4307,6 @@ int ext4_force_commit(struct super_block *sb) > return ret; > } > > -static void ext4_write_super(struct super_block *sb) > -{ > - lock_super(sb); > - ext4_commit_super(sb, 1); > - unlock_super(sb); > -} > - > static int ext4_sync_fs(struct super_block *sb, int wait) > { > int ret = 0; > -- > 1.7.7.6 > -- Jan Kara SUSE Labs, CR