From: Marco Stornelli Subject: Re: [PATCH 1/8] vfs: remove lock and unlock functions for super block Date: Thu, 16 Aug 2012 18:05:04 +0200 Message-ID: <502D1A30.4010109@gmail.com> References: <502CC499.4030109@gmail.com> <502CE700.3070709@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: bhalevy@tonian.com, jack@suse.cz, Andrew Morton , adilger.kernel@dilger.ca, tytso@mit.edu, hirofumi@mail.parknet.co.jp, mikulas@artax.karlin.mff.cuni.cz, Al Viro , hch@infradead.org, dushistov@mail.ru, osd-dev@open-osd.org, Linux Kernel , linux-ext4@vger.kernel.org, Linux FS Devel To: Boaz Harrosh Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:65167 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403Ab2HPQLf (ORCPT ); Thu, 16 Aug 2012 12:11:35 -0400 In-Reply-To: <502CE700.3070709@panasas.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Il 16/08/2012 14:26, Boaz Harrosh ha scritto: > On 08/16/2012 12:59 PM, Marco Stornelli wrote: > >> From: Marco Stornelli >> >> Remove lock_super and unlock_super from VFS. >> >> Signed-off-by: Marco Stornelli > > > You can't remove the lock here. After this patch the tree will > not compile, and will not be bisectable. You must move this patch > to be last. > > Each patch should leave the tree compileable and with out any > regressions. > > Boaz > Yep, you're right. I'll resend it in the right order at the end of first review. Thanks, Marco