From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH] ext4: Automatic setting of {INODE,BLOCK}_UNINIT flags Date: Thu, 25 Oct 2012 15:59:38 +0200 (CEST) Message-ID: References: <1351149943-4827-1-git-send-email-tracek@redhat.com> <20121025125408.GA17378@gmail.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="571107329-1712698633-1351173586=:14460" Cc: Yongqiang Yang , =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= , Tomas Racek , linux-ext4@vger.kernel.org To: Zheng Liu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161121Ab2JYN7r (ORCPT ); Thu, 25 Oct 2012 09:59:47 -0400 In-Reply-To: <20121025125408.GA17378@gmail.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --571107329-1712698633-1351173586=:14460 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Thu, 25 Oct 2012, Zheng Liu wrote: > Date: Thu, 25 Oct 2012 20:54:09 +0800 > From: Zheng Liu > To: Yongqiang Yang > Cc: Luk?? Czerner , Tomas Racek , > linux-ext4@vger.kernel.org > Subject: Re: [PATCH] ext4: Automatic setting of {INODE,BLOCK}_UNINIT flags > > On Thu, Oct 25, 2012 at 07:39:06PM +0800, Yongqiang Yang wrote: > > > > > > So my question is, why do you think this might not make sense in no > > > journal mode ? Maybe I am missing something. > > Yep, advantage is obvious, in no journal mode, if we delete a file > > which is the last inode in a block group, and the uninit flag of inode > > bitmap is flused to disk and directory referring the inode is not > > flushed, I don't know how fsck handles the situation currently. If > > fsck handles the situation, everything is ok. I meant maybe we should > > check fsck too. > > Hi Yongqiang, > > It seems that it couldn't happen whether it is in no journal mode or > journal mode. When a file is deleted, the dir entry will be updated > firstly, and then the block will be freed. So the block is freed after > the dir entry is updated. So when the last inode is freed, the dir > entry must be flushed to the disk. Am I missing something? I think you're right. Doing this the other way around would be a bug regardless on this patch. Thanks! -Lukas > > Regards, > Zheng > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --571107329-1712698633-1351173586=:14460--