From: Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 1/1] ext4: Remove duplicate inclusion of ext4_extents.h
 in super.c
Date: Mon, 19 Nov 2012 10:00:00 -0500
Message-ID: <20121119150000.GA29807@thunk.org>
References: <1353323842-32283-1-git-send-email-sachin.kamat@linaro.org>
 <20121119133944.GA11095@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: Sachin Kamat <sachin.kamat@linaro.org>, linux-ext4@vger.kernel.org,
	adilger.kernel@dilger.ca, patches@linaro.org
Content-Disposition: inline
In-Reply-To: <20121119133944.GA11095@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org

On Mon, Nov 19, 2012 at 09:39:45PM +0800, Zheng Liu wrote:
> Hi Sachin,
> 
> Sorry, I don't find this duplicated code in mainline kernel 3.7-rc6.

It's there because ext4.h includes ext4_extents.h -- at the end of the
header file, where it's not quite as obvious.

What we should probably do is move the function declarations into
ext4.h, and then see if we can isolate the number of fs/ext4/*.c files
that are aware of the on-disk extents encoding, such that it doesn't
make sense to #include ext4_extenst.h from the ext4.h header file.

It's mainly a cleanup thing, but it would probably also help if we
ever want to support alternate extents encodings (for example to
support a full 64-bit physical block numbers, or more likely, more
than 32 bits worth of logical block nunbers --- so we can test large
file systems natively using ext4, instead of using xfs, which is what
I currently do).  That's a low priority thing in my book, but if
someone is interesting in taking on the project, they should let me
know.

   	     	 	       	      	  - Ted