From: Fengguang Wu Subject: Re: [ext4:dev 56/60] fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers Date: Mon, 3 Dec 2012 14:18:36 +0800 Message-ID: <20121203061836.GA12998@localhost> References: <50bc34a0.y/JP4a0udwG4qbxZ%fengguang.wu@intel.com> <50BC3AB0.1060708@tao.ma> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Tao Ma , linux-ext4@vger.kernel.org, Theodore Ts'o To: Tao Ma Return-path: Received: from mga01.intel.com ([192.55.52.88]:47349 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130Ab2LCGSz (ORCPT ); Mon, 3 Dec 2012 01:18:55 -0500 Content-Disposition: inline In-Reply-To: <50BC3AB0.1060708@tao.ma> Sender: linux-ext4-owner@vger.kernel.org List-ID: Tao, Perhaps you can create an incremental fix, which allows Ted to easily check how it's fixed, and have the freedom to either fold it to the bad commit, or to append to HEAD. Thanks, Fengguang On Mon, Dec 03, 2012 at 01:37:52PM +0800, Tao Ma wrote: > Great thanks, Fengguang. > > So Ted, > do you want me to send a new patch set? Or you just want me to generate > a patch for all these warnings Fengguang found? > > Thanks > Tao > > > On 12/03/2012 01:12 PM, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > > head: e9f49e454264c1cdd793552bfeb44f337508201b > > commit: a7b0168d4a9bb78535827ddaf9c055963f5bd7aa [56/60] ext4: let fallocate handle inline data correctly > > config: i386-randconfig-m085 (attached as .config) > > > > All error/warnings: > > > > In file included from fs/ext4/dir.c:30:0: > > fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers > > fs/ext4/xattr.h:422:16: warning: 'ext4_convert_inline_data' defined but not used [-Wunused-function] > > -- > > In file included from fs/ext4/extents.c:45:0: > > fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers > > > > vim +422 fs/ext4/xattr.h > > > > 18dfee69 Tao Ma 2012-12-02 416 static inline void ext4_inline_data_truncate(struct inode *inode, > > 18dfee69 Tao Ma 2012-12-02 417 int *has_inline) > > 18dfee69 Tao Ma 2012-12-02 418 { > > 18dfee69 Tao Ma 2012-12-02 419 return; > > 18dfee69 Tao Ma 2012-12-02 420 } > > 18dfee69 Tao Ma 2012-12-02 421 > > a7b0168d Tao Ma 2012-12-02 @422 static int int ext4_convert_inline_data(struct inode *inode) > > a7b0168d Tao Ma 2012-12-02 423 { > > a7b0168d Tao Ma 2012-12-02 424 return 0; > > a7b0168d Tao Ma 2012-12-02 425 } > > > > --- > > 0-DAY kernel build testing backend Open Source Technology Center > > Fengguang Wu, Yuanhan Liu Intel Corporation > >