From: Eric Sandeen Subject: Re: [PATCH 2/5] mke2fs: the -g option will now specify the clusters per block group Date: Tue, 15 Jan 2013 09:10:41 -0600 Message-ID: <50F57171.6030701@redhat.com> References: <20130114211014.GA22642@thunk.org> <1358210232-30578-1-git-send-email-tytso@mit.edu> <1358210232-30578-2-git-send-email-tytso@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Ext4 Developers List , gnehzuil.liu@gmail.com To: "Theodore Ts'o" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9480 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795Ab3AOPKv (ORCPT ); Tue, 15 Jan 2013 10:10:51 -0500 In-Reply-To: <1358210232-30578-2-git-send-email-tytso@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 1/14/13 6:37 PM, Theodore Ts'o wrote: > If bigalloc is enabled, then -g will specify the clusters per block > group. (If bigalloc is not enabled, then a cluster == a block, so the > meaning of -g is not changed.) This should be clearly documented in the man page as well, I think. -Eric > Signed-off-by: "Theodore Ts'o" > --- > misc/mke2fs.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/misc/mke2fs.c b/misc/mke2fs.c > index 75d0e48..5cb49b3 100644 > --- a/misc/mke2fs.c > +++ b/misc/mke2fs.c > @@ -1962,6 +1962,15 @@ profile_error: > } > } > > + /* > + * If the bigalloc feature is enabled, then the -g option will > + * specify the number of clusters per group. > + */ > + if (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) { > + fs_param.s_clusters_per_group = fs_param.s_blocks_per_group; > + fs_param.s_blocks_per_group = 0; > + } > + > if (inode_size == 0) > inode_size = get_int_from_profile(fs_types, "inode_size", 0); > if (!flex_bg_size && (fs_param.s_feature_incompat & >