From: "Frank Ch. Eigler" Subject: Re: Excessive stall times on ext4 in 3.9-rc2 Date: Mon, 8 Apr 2013 06:52:53 -0400 Message-ID: <20130408105253.GA5275@redhat.com> References: <20130402142717.GH32241@suse.de> <20130402150651.GB31577@thunk.org> <20130402151436.GC31577@thunk.org> <20130402181940.GA4936@thunk.org> <20130408083645.GC2623@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, LKML , Linux-MM , Jiri Slaby To: Mel Gorman Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55129 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935424Ab3DHKyY (ORCPT ); Mon, 8 Apr 2013 06:54:24 -0400 Content-Disposition: inline In-Reply-To: <20130408083645.GC2623@suse.de> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi, Mel - > > [...] git kernel developers > > should use git systemtap, as has always been the case. [...] > > At one point in the past this used to be the case but then systemtap had to > be compiled as part of automated tests across different kernel versions. It > could have been worked around in various ways or even installed manually > when machines were deployed but stap-fix.sh generally took less time to > keep working. OK, if that works for you. Keep in mind though that newer versions of systemtap retain backward-compatibility for ancient versions of the kernel, so git systemtap should work on those older versions just fine. > [...] > Yes, this was indeed the problem. The next version of watch-dstate.pl > treated get_request_wait() as a function that may or may not exist. It > uses /proc/kallsyms to figure it out. ... or you can use the "?" punctuation in the script to have systemtap adapt: probe kprobe.function("get_request_wait") ? { ... } - FChE