From: "H. Peter Anvin" Subject: Re: [PATCH v2] x86: make DR*_RESERVED unsigned long Date: Sun, 28 Apr 2013 10:32:42 -0700 Message-ID: <517D5D3A.8070505@zytor.com> References: <20130424072630.GB1780@gmail.com> <20130424170702.GA1867@redhat.com> <5178282D.9030902@zytor.com> <20130425144818.GA25921@redhat.com> <20130426163802.GA30351@redhat.com> <517AAED5.7040400@zytor.com> <20130426171526.GA30875@redhat.com> <20130427144537.GA24256@redhat.com> <20130428005814.GB10354@somewhere> <20130428172731.GA26169@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Frederic Weisbecker , Ingo Molnar , Linus Torvalds , Cyrill Gorcunov , Peter Zijlstra , Thomas Gleixner , David Miller , "Theodore Ts'o" , Linux Kernel Mailing List , the arch/x86 maintainers , Network Development , "linux-ext4@vger.kernel.org" To: Oleg Nesterov Return-path: In-Reply-To: <20130428172731.GA26169@redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On 04/28/2013 10:27 AM, Oleg Nesterov wrote: > On 04/28, Frederic Weisbecker wrote: >> >> On Sat, Apr 27, 2013 at 04:45:37PM +0200, Oleg Nesterov wrote: >>> >>> -/* Define reserved bits in DR6 which are always set to 1 */ >>> -#define DR6_RESERVED (0xFFFF0FF0) >>> +#define DR6_MASK (0xF00FU) /* Everything else is reserved */ >> >> I'm personally fine either with that or with Peter's suggestion to do: >> >> -#define DR6_RESERVED (0xFFFF0FF0) >> +#define DR6_RESERVED (~0xF00FUL) > > I missed this suggestion... > > Yes, and this allows to kill ifdef too. > >> If this should stay stable UAPI, > > I do not know, but I guess it would be safer to keep the old define's. > >> I really don't mind. > > Oh, I do not mind too ;) > > OK, please see v3. > Looks good. However, given the timing, I would think this is 3.11 material unless we have a manifest bug at this point. I have several bits like this that I'm going to queue up in a separate tip branch. -hpa