From: Thavatchai Makphaibulchoke Subject: Re: [PATCH v3 0/2] ext4: increase mbcache scalability Date: Fri, 13 Sep 2013 06:04:14 -0600 Message-ID: <5232FF3E.7080604@hp.com> References: <5229C939.8030108@hp.com> <62D71A85-C7EE-4F5F-B481-5329F0282044@dilger.ca> <20130910210250.GH29237@thunk.org> <522FDFCC.1070007@redhat.com> <20130911113001.GB13315@thunk.org> <52309F27.8060008@redhat.com> <5230D739.9010109@redhat.com> <20130911212523.GE13397@thunk.org> <5230D450.7000609@hp.com> <20130912122317.GC12918@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Eric Sandeen , David Lang , Andreas Dilger , T Makphaibulchoke , "linux-ext4@vger.kernel.org List" , aswin@hp.com, aswin_proj@lists.hp.com To: Theodore Ts'o Return-path: Received: from g4t0015.houston.hp.com ([15.201.24.18]:10654 "EHLO g4t0015.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941Ab3IMSHT (ORCPT ); Fri, 13 Sep 2013 14:07:19 -0400 In-Reply-To: <20130912122317.GC12918@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 09/12/2013 06:23 AM, Theodore Ts'o wrote: > (I've trimmed the cc list to stop spamming people who probably don't > care as much about this). > > So I've tried the following patch, and I've confirmed that for short > xattrs (i.e., that fit inside the inode body, assuming an inode size > > 128 bytes), the mbcache paths don't trigger at all. > > Could you try this patch and see if we can figure out why mbcache code > paths are triggering for you? > > - Ted > I tried the patch. First off, looks like the patch has a lot of warnings, it does produces tremendous non-stop warnings during aim7 run, particularly the one from line 1627. Unfortunately, looks like with this patch we are still calling ext4_xattr_cache_find(). I added more debugging code to print out the first few xattrs that get us into ex4_xattr_cache_find(). This is what I have, [ 80.540977] ext4_xattr_block_set: name len 28. [ 155.480692] ext4_xattr_block_set: name selinux len 32. [ 155.486531] ext4_xattr_block_set: name selinux len 32. [ 155.492283] ext4_xattr_block_set: name selinux len 32. [ 155.497988] ext4_xattr_block_set: name selinux len 32. [ 155.504064] ext4_xattr_block_set: name selinux len 32. [ 155.509771] ext4_xattr_block_set: name selinux len 32. [ 155.515475] ext4_xattr_block_set: name selinux len 32. [ 155.521179] ext4_xattr_block_set: name selinux len 32. I'll continue debugging and get back with any new finding. Thanks, Mak.