From: Jan Kara Subject: Re: fix the ext4_read_inline_dir return value Date: Tue, 17 Sep 2013 18:29:16 +0200 Message-ID: <20130917162916.GA16938@quack.suse.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-ext4@vger.kernel.org" , Theodore Tso , Robin Dong , "tm@tao.ma" , "lewis.liulei" , pamirs To: Boxi Liu Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34633 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914Ab3IQQ3Y (ORCPT ); Tue, 17 Sep 2013 12:29:24 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue 17-09-13 23:08:51, Boxi Liu wrote: > hi=EF=BC=8C > there may be a bug in ext4_read_inline_dir() function with inline_dat= a feature. > when I recursion call a sys_old_readdir to read a direntry's > sub_dentry,I find that the ext4_read_inline_dir return the len of the > inline_data ,but in the no inline_data case,it will return 0.It is > inconsistent. > So I try to make a patch to fix it. The patch is fine, thanks for finding the bug. But please read Documentation/SubmittingPatches about how your patch should be formatte= d. In particular your patch has damaged whitespace (tabs converted to spac= es). Gmail does this - you have to send the patch as an attachment to avoid = this when using gmail. Also your patch misses Signed-off-by line. Honza >=20 > diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c > index d9ecbf1..3ea39cd 100644 > --- a/fs/ext4/inline.c > +++ b/fs/ext4/inline.c > @@ -1441,7 +1441,7 @@ int ext4_read_inline_dir(struct file *file, > up_read(&EXT4_I(inode)->xattr_sem); > if (ret < 0) > goto out; > - > + ret =3D 0; > sb =3D inode->i_sb; > parent_ino =3D le32_to_cpu(((struct ext4_dir_entry_2 *)dir_buf)->in= ode); > offset =3D ctx->pos; > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html